[Bug 241751] [PATCH] security/sshguard: remove redundant pidfile check

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241751

            Bug ID: 241751
           Summary: [PATCH] security/sshguard: remove redundant pidfile
                    check
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: delphij at FreeBSD.org
                CC: dan.mcgregor at usask.ca
                CC: dan.mcgregor at usask.ca
             Flags: maintainer-feedback?(dan.mcgregor at usask.ca)

Created attachment 208906
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208906&action=edit
Proposed patch

The new SSHguard script performs an incomplete check of pidfile, which is not
needed on FreeBSD and can prevent the service from starting.  The issue seems
to be introduced by
https://bitbucket.org/sshguard/sshguard/commits/32a4676599a900a7a072f66303d9c48b22d1107c

Reproduction case:

1. echo "blah" > /var/run/sshguard.pid
2. service sshguard start

Expected result:

sshguard should start and write the PID.

Actual result:

sshguard won't start; if the command was executed manually, the user would see
"/var/run/sshguard.pid already exists; is SSHGuard already running?".

Proposed patch attached.

-- 
You are receiving this mail because:
You are the assignee for the bug.