[Bug 241719] print/texinfo: fix NLS build, part 2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241719

            Bug ID: 241719
           Summary: print/texinfo: fix NLS build, part 2
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: sunpoet at FreeBSD.org
          Reporter: jcfyecrayz at liamekaens.com
          Assignee: sunpoet at FreeBSD.org
             Flags: maintainer-feedback?(sunpoet at FreeBSD.org)

After ports/r515761, the build now gets missing prototype warnings like so:

parsetexi/api.c:74:7: warning: implicit declaration of function
'bindtextdomain' is invalid in C99 [-Wimplicit-function-declaration]
      bindtextdomain (PACKAGE, s);
      ^
parsetexi/api.c:89:5: warning: implicit declaration of function
'bindtextdomain' is invalid in C99 [-Wimplicit-function-declaration]
    bindtextdomain (PACKAGE, LOCALEDIR);
    ^
parsetexi/api.c:91:3: warning: implicit declaration of function 'textdomain' is
invalid in C99 [-Wimplicit-function-declaration]
  textdomain (PACKAGE);


There are a few problems involved:

 (a) The top level configure does not detect libintl.h, so it does not define
HAVE_LIBINTL_H (because it doesn't look in /usr/local/include).

 (b) Even if it did set HAVE_LIBINTL_H (add USES=localbase would do the job),
the configure that is run in tp/Texinfo/XS is different.  It does not even try
to detect libintl.h and so it also does not set HAVE_LIBINTL_H.  This means
libintl.h is never included which triggers the compiler warnings.


Thus, the change in ports/r515761 effectively just comment out the include of
libintl.h.  An #if 0 would have done just as well.


A fix for (a) is "NLS_USES=gettext localbase" (instead of NLS_USES=gettext).


A fix for (b) is to teach tp/Texinfo/XS/configure(.ac) to look for libintl.h -
perhaps use the same method the top level configure uses.

-- 
You are receiving this mail because:
You are the assignee for the bug.