[Bug 240788] [NEW PORT] sysutils/ansible-sysrc: Ansible module to set sysvars in rc.conf

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240788

--- Comment #23 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
Comment on attachment 208827
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=208827
port diff

Removing the call to ansible-config finally made the port build fine here. The
difference could be that I'm using poudriere-devel, but other than that I'm
just invoking `poudriere testport -p default -j 13amd64 -i -o
sysutils/ansible-sysrc' and have DEVELOPER_MODE=yes in make.conf.

As for the patch, one thing that can still be improved:

+ANSIBLE_MOD=   ${PREFIX}/share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/modules
+
+PLIST_FILES=   $$(${ECHO_CMD} ${ANSIBLE_MOD} | ${SED} -e
's|${PREFIX}/||')/sysrc

The echo+sed combination is unnecessary, remember you're setting ANSIBLE_MOD
yourself. My suggestion is to do something like

  ANSIBLE_MOD_REL= share/${PYTHON_PKGNAMEPREFIX}ansible/plugins/modules
  PLIST_FILES= ${ANSIBLE_MOD_REL}/sysrc
  do-install:
    [...]
    ${INSTALL_SCRIPT} ${WRKSRC}/library/sysrc
${STAGEDIR}${PREFIX}/${ANSIBLE_MOD_REL}/sysrc

-- 
You are receiving this mail because:
You are the assignee for the bug.