[Bug 236845] sysutils/syslog-ng320: Don't drag in python when PYTHON isn't selected, other fixes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236845

            Bug ID: 236845
           Summary: sysutils/syslog-ng320: Don't drag in python when
                    PYTHON isn't selected, other fixes
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: cy at FreeBSD.org
          Reporter: leres at freebsd.org
          Assignee: cy at FreeBSD.org
             Flags: maintainer-feedback?(cy at FreeBSD.org)

I have DEFAULT_VERSIONS=python3=3.7 and noticed poudriere was also
building python36. When I investigated I found it was being built due to
syslog-ng (syslog-ng320) which had several issues:

 - unconditional USES=python:3.6,build
 - PYTHON_CONFIGURE_OFF=--disable-python --with-python=3.6
 - other general hardcoding to python36

In my testing python I found isn't used at all with --disable-python.

When PYTHON is enabled there are many byacc errors:

    /bin/sh ./ylwrap modules/afsmtp/afsmtp-grammar.y y.tab.c
modules/afsmtp/afsmtp-grammar.c y.tab.h modules/afsmtp/afsmtp-grammar.h
y.output modules/afsmtp/afsmtp-gramm
    ar.output -- byacc -Wno-yacc -Wno-other -d 2>&1 | (/usr/bin/egrep -v
"(warning: ([0-9]+ )?(nonterminal|rule)s? useless in
grammar)|(^updating|unchanged)" || true)
    /bin/sh ./ylwrap modules/afsmtp/afsmtp-grammar.y y.tab.c
modules/afsmtp/afsmtp-grammar.h y.tab.h modules/afsmtp/afsmtp-grammar.h
y.output modules/afsmtp/afsmtp-gramm
    ar.output -- byacc -Wno-yacc -Wno-other -d 2>&1 | (/usr/bin/egrep -v
"(warning: ([0-9]+ )?(nonterminal|rule)s? useless in
grammar)|(^updating|unchanged)" || true)
    Usage: byacc [options] filename

    Options:
      -b file_prefix        set filename prefix (default "y.")
      -B                    create a backtracking parser
    [...]

A configure message seems to indicate that it would prefer bison:

    configure: WARNING: No proper bison found, you'll not be able to change
lib/cfg-grammar.y

I added PYTHON_USES=bison:build and this solved the errors.

I removed USES=python:3.6,build and added PYTHON_USES=python:3.5+,build
to all use of any of the python3 versions and changed other python version
references to use the PYTHON_VER and PYTHON_SUFFIX variables.

I also removed SHEBANG_LANG=python3 because there are no dependencies
that would cause the python3 meta port to be installed and thus no python3 on
the path.

While here fix some portlint nits:

 - use tab (not space) to make indentation
 - whitespace before end of line
 - order (e.g. DISTFILES and USES)
 - unnecessary ${INSTALL} -o/-g

-- 
You are receiving this mail because:
You are the assignee for the bug.