[Bug 235121] shells/rssh: rssh crashes on invocation due to new basename(3) POSIX behaviour

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=235121

            Bug ID: 235121
           Summary: shells/rssh: rssh crashes on invocation due to new
                    basename(3) POSIX behaviour
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: topical at gmx.net
                CC: jharris at widomaker.com
             Flags: maintainer-feedback?(jharris at widomaker.com)
                CC: jharris at widomaker.com

In FreeBSD 12.0, basename(3) was changed to be POSIX compliant. This implies
that it can possibly write to the passed string.

rssh passes a const string, so it always crashes on invocation.

There are 2 solutions:

  * modify basename(3) so it only modifies the string if it has to
  * modify rssh, making a copy of the string first and pass it instead

The first solution may help other ports as well but I know that it will take
some time until this change will be public. Meanwhile we could fix at least
this single port by making it more POSIX compliant.

-- 
You are receiving this mail because:
You are the assignee for the bug.