[Bug 234822] [PATCH] sysutils/tmux: Add utf8proc option to Makefile

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234822

            Bug ID: 234822
           Summary: [PATCH] sysutils/tmux: Add utf8proc option to Makefile
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: mat at FreeBSD.org
          Reporter: dor.bsd at xm0.uk
          Assignee: mat at FreeBSD.org
             Flags: maintainer-feedback?(mat at FreeBSD.org)

Created attachment 200987
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=200987&action=edit
sysutils/tmux: Add utf8proc option to Makefile

This patch adds an option to compile tmux with utf8proc support, and defaults
it to on.

This patch comes after I spent a while tracking down why I was having issues
with various characters in the terminal and reading through
https://github.com/tmux/tmux/issues/1057. Within that issue, there is a
newtest.txt file which I was using to test tmux in a reliable way.

The characters within the file are a "hugging face" and a "glowing star". They
are definitely printable characters. They're listed at emojipedia as:
  - https://emojipedia.org/glowing-star/
  - https://emojipedia.org/hugging-face/

Tmux compiled without utf8proc will show the following when displaying the
above file:
Unicode 1f917, wcwidth() -1
input_top_bit_set 4 '\360\237\244\227' (width 1)
Unicode 1f31f, wcwidth() -1
input_top_bit_set 4 '\360\237\214\237' (width 1)

The wcwidth() lines are showing that wcwidth(3) failed to properly detect the
character width, which leads to display issues later on.

Once compiled against utf8proc, the above becomes:
input_top_bit_set 4 '\360\237\244\227' (width 2)
input_top_bit_set 4 '\360\237\214\237' (width 2)

The character width is correctly detected and display issues no longer happen.

I made this an option instead of just enabling it in the CONFIGURE_ARGS since
maybe someone, somewhere depends on the odd wcwidth() behaviour.

-David

-- 
You are receiving this mail because:
You are the assignee for the bug.