[Bug 236060] databases/postgresql11-server: pkg-message-server.in is wrong about login classes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236060

            Bug ID: 236060
           Summary: databases/postgresql11-server: pkg-message-server.in
                    is wrong about login classes
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: pgsql at FreeBSD.org
          Reporter: michael.osipov at siemens.com
          Assignee: pgsql at FreeBSD.org
             Flags: maintainer-feedback?(pgsql at FreeBSD.org)

The file says:

> Then add 'postgresql_class="postgres"' to /etc/rc.conf.

I believe that this is wrong because the manpage of rc.subr(8) says:

> ${name}_login_class
>	Login class to use with ${name}_limits.  Defaults
> 	to ``daemon''.

So I expect it to be 'postgresql_login_class="postgres"'.

This issue seems to exist multiple times:

> [mosipov at mika-ion /usr/ports/databases]$ grep -r postgresql_class .
> ./postgresql10-server/files/postgresql.in:#  postgresql_class="default"
> ./postgresql10-server/files/postgresql.in:postgresql_class=${postgresql_class:-"default"}
> ./postgresql10-server/files/postgresql.in:    ${su_cmd} -l -c ${postgresql_class} ${postgresql_user} -c "exec %%PREFIX%%/bin/initdb ${postgresql_initdb_flags} -D ${postgresql_data} -U ${postgresql_user}"
> ./postgresql10-server/files/pkg-message-server.in:Then add 'postgresql_class="postgres"' to /etc/rc.conf.
> ./postgresql94-server/files/pkg-message-server.in:Then add 'postgresql_class="postgres"' to /etc/rc.conf.
> ./postgresql94-server/files/postgresql.in:#  postgresql_class="default"
> ./postgresql94-server/files/postgresql.in:postgresql_class=${postgresql_class:-"default"}
> ./postgresql94-server/files/postgresql.in:    ${su_cmd} -l -c ${postgresql_class} ${postgresql_user} -c "exec %%PREFIX%%/bin/initdb ${postgresql_initdb_flags} -D ${postgresql_data} -U ${postgresql_user}"
> ./postgresql95-server/files/postgresql.in:#  postgresql_class="default"
> ./postgresql95-server/files/postgresql.in:postgresql_class=${postgresql_class:-"default"}
> ./postgresql95-server/files/postgresql.in:    ${su_cmd} -l -c ${postgresql_class} ${postgresql_user} -c "exec %%PREFIX%%/bin/initdb ${postgresql_initdb_flags} -D ${postgresql_data} -U ${postgresql_user}"
> ./postgresql95-server/files/pkg-message-server.in:Then add 'postgresql_class="postgres"' to /etc/rc.conf.
> ./postgresql96-server/files/postgresql.in:#  postgresql_class="default"
> ./postgresql96-server/files/postgresql.in:postgresql_class=${postgresql_class:-"default"}
> ./postgresql96-server/files/postgresql.in:    ${su_cmd} -l -c ${postgresql_class} ${postgresql_user} -c "exec %%PREFIX%%/bin/initdb ${postgresql_initdb_flags} -D ${postgresql_data} -U ${postgresql_user}"
> ./postgresql96-server/files/pkg-message-server.in:Then add 'postgresql_class="postgres"' to /etc/rc.conf.
> ./postgresql11-server/files/pkg-message-server.in:Then add 'postgresql_class="postgres"' to /etc/rc.conf.
> ./postgresql11-server/files/postgresql.in:#  postgresql_class="default"
> ./postgresql11-server/files/postgresql.in:postgresql_class=${postgresql_class:-"default"}
> ./postgresql11-server/files/postgresql.in:    ${su_cmd} -l -c ${postgresql_class} ${postgresql_user} -c "exec %%PREFIX%%/bin/initdb ${postgresql_initdb_flags} -D ${postgresql_data} -U ${postgresql_user}"
>

-- 
You are receiving this mail because:
You are the assignee for the bug.