[Bug 230916] [patch] x11-wm/ccsm: add LICENSE and option NLS

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Sun Feb 24 04:04:16 UTC 2019


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230916

Samy Mahmoudi <samy.mahmoudi at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201971|0                           |1
        is obsolete|                            |

--- Comment #12 from Samy Mahmoudi <samy.mahmoudi at gmail.com> ---
Created attachment 202311
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=202311&action=edit
Patch file generated with svn diff

(In reply to Tobias Kortkamp from comment #11)

> Kudos for making it work, but this is adds 8 new patches.  Is it really worth it?
I dropped 7 patches with a post-patch definition and a for loop ;-)

More seriously, this NLS option was initially suggested by portlint while I was
keeping all the compiz ports up-to-date. Thereafter, it seemed worth to me to
offer option NLS for users who globally set NLS to off by adding
OPTIONS_UNSET+=NLS to their make.conf, even though I am not one of these (I am
a French native speaker).

> Do you plan to upstream the changes (assuming they are active)?
I do not because compiz is dead (to such a point that sources are currently
fetched from the FreeBSD distribution cache). There is, however, a community
around compiz-reloaded and I have already submitted changes to the build system
to increase portability and eventually port compiz-reloaded to FreeBSD
(https://gitlab.com/compiz/compiz-core/merge_requests/121). I think they do not
have the time to review my work, so I am seriously thinking to create a new
port with the changes done within the FreeBSD port system and to resubmit the
changes upstream, independently, in small chunks to ease in review.

So my goal is to port compiz-reloaded to FreeBSD. During that transition and
before considering any drop, we need to keep the compiz ports in the ports
tree, preferably in a clean state.

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list