[Bug 242557] graphics/qgis: Update to 3.10.1

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242557

Raphael Kubo da Costa <rakuco at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|ports-bugs at FreeBSD.org      |rakuco at FreeBSD.org

--- Comment #4 from Raphael Kubo da Costa <rakuco at FreeBSD.org> ---
A few comments related to the LLVM+QMap issues:
* Upstream's also patched src/core/CMakeLists.txt to add -mllvm
-inline-threshold=128, isn't it better to import that patch and reference the
upstream commit?
* The part in the Makefile changing those flags to -O1, how about referencing
bug 241687 in the comment and checking __FreeBSD_version to decide whether to
apply it? IIUC, 11.3 is the oldest supported release, and it already includes
LLVM 8.0 and does not need the change to -O1; 12.0 is broken, but 12.1 is not,
as the latter also has LLVM 8.0. Per
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/versions-12.html,
I guess something like __FreeBSD_version >= 1200000 && __FreeBSD_version <
1200506 would be enough, and it also makes it easier to drop this check once
12.0 is no longer supported.

-- 
You are receiving this mail because:
You are the assignee for the bug.