[Bug 242619] Mk/bsd.port.mk: Messaging around ALLOW_UNSUPPORTED_SYSTEM is confusing
bugzilla-noreply at freebsd.org
bugzilla-noreply at freebsd.org
Sun Dec 15 01:57:38 UTC 2019
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=242619
Kubilay Kocak <koobs at FreeBSD.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|Works As Intended |---
Status|Closed |Open
Summary|freebsd 11.3-p5: Ports |Mk/bsd.port.mk: Messaging
|Collection support for your |around
|FreeBSD version has ended |ALLOW_UNSUPPORTED_SYSTEM is
| |confusing
Keywords| |needs-qa
--- Comment #9 from Kubilay Kocak <koobs at FreeBSD.org> ---
(In reply to Chris Hutchinson from comment #8)
I can't *unequivocally* speak to the original intention, but looking at the
relevant block in Mk/bsd.port.mk:
- There are two 'variations' of the message depending on whether
ALLOW_UNSUPPORTED_SYSTEM is defined or not, and
- *both* conditions include the same message as their first section,
- with the latter (when not defined) additionally including the "... if you
silence this message by defining ALLOW_UNSUPPORTED_SYSTEM"
To me, that indicates that defining ALLOW_UNSUPPORTED_SYSTEM was *not* supposed
to or intended get rid of the EoL messaging *completely*.
I conclude that the mechanism indeed 'works as intended' on the above basis,
but I believe there is some messaging improvements to be made, as I can see how
"silence this message" could be taken to mean "not see any message about this
EoL condition *at all*", rather than "just remove the messaging about being
able to use the ALLOW_UNSUPPORTED_SYSTEM variable"
I would propose a simple change such as:
- No support will be provided if you *silence this message* by defining
ALLOW_UNSUPPORTED_SYSTEM.
+ No support will be provided if you *override this error* by defining
ALLOW_UNSUPPORTED_SYSTEM in /etc/make.conf
--
You are receiving this mail because:
You are on the CC list for the bug.
More information about the freebsd-ports-bugs
mailing list