[Bug 240237] security/barnyard2: Mark ODBC option as broken, fix options helper usage

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=240237

            Bug ID: 240237
           Summary: security/barnyard2: Mark ODBC option as broken, fix
                    options helper usage
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Keywords: patch
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: bofh at freebsd.org
          Reporter: tobik at freebsd.org
                CC: bofh at freebsd.org
             Flags: maintainer-feedback?(bofh at freebsd.org)
          Assignee: bofh at freebsd.org
 Attachment #207049 maintainer-approval?(bofh at freebsd.org)
             Flags:
                CC: bofh at freebsd.org

Created attachment 207049
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=207049&action=edit
barnyard2.diff

First there is no ODBC_WITH options helper and it should be
ODBC_CONFIGURE_WITH.
However while the ODBC feature is now actually activated, the port will no
longer build with ODBC=on due to lack of support in the code. Let's mark the
ODBC option as broken.  Previously turning the option on was a nop.
Alternatively, the option could maybe just be removed.

spo_database.c:3547:3: error: use of undeclared identifier 'result'
                result = 0;
                ^
spo_database.c:3841:41: warning: incompatible pointer types passing 'SQLINTEGER
*' (aka 'int *') to parameter of type 'SQLLEN *' (aka 'long *')
[-Wincompatible-pointer-types]
                    if(SQLRowCount(data->u_statement, &data->u_rows) ==
SQL_SUCCESS)
                                                      ^~~~~~~~~~~~~
/usr/local/include/sql.h:768:44: note: passing argument to parameter 'RowCount'
here
                                   SQLLEN *RowCount);
                                           ^
spo_database.c:3849:33: error: use of undeclared identifier 'result'
                                result = 0;
                                ^
1 warning and 2 errors generated.

-- 
You are receiving this mail because:
You are the assignee for the bug.