[Bug 238780] converters/pdf2djvu: fix build with GCC-based architectures

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238780

--- Comment #17 from Samy Mahmoudi <samy.mahmoudi at gmail.com> ---
(In reply to Samy Mahmoudi from comment #11)
> .if ${ARCH:Mmips*} || ${ARCH:Mpowerpc*} || ${ARCH} == sparc64
> Is your GCC-architecture included in the previous conditionals ?
Based on comment 16, I assume it is.


(In reply to Piotr Kubaj from comment #16)
> In fact, powerpc* on head soon switches to clang.
Thanks for this information, I did not know that would happen soon, but... 


(In reply to Piotr Kubaj from comment #16)
> This assumes that powerpc* uses GCC which won't hold true forever.
...the conditional expression was not meant to be immutable, e.g. to add new
GCC-architectures when needed, or to remove the ones clang become functional
on. Software sometimes needs to be maintained, even with the best software
methodologies and practices.

> Why not set USES=compiler:c++11-lang?
This was the default under which you had to file a bug report, so this would
only bring us back to Description (comment 0) and subsequent comments. Do you
mean USES=compiler:c++11-lib ? I am reading Mk/Uses/compiler.mk and will give
it a try. If this automatically chooses between clang and gcc depending on
architecture, it would avoid us to have to maintain the conditional. This would
definitely be a better practice !

-- 
You are receiving this mail because:
You are the assignee for the bug.