[Bug 236944] security/strongswan: startup script improvements

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236944

--- Comment #6 from Jose Luis Duran <jlduran at gmail.com> ---
(In reply to Sam Chen from comment #5)

Thank you for taking the time to review the patch:

1) I tried to keep it similar to ipsec.in, currently the failing exit code for
reload is 7:

https://github.com/strongswan/strongswan/blob/5c38a5ea832accec3a8d3942d878ac5be5bb2a4b/src/ipsec/_ipsec.in#L171

2) The idea is not to use a hard-coded sleep, else I would prefer to use 2
seconds, which is what ipsec.in is currently using (see comment #0). The idea
is that if $charon_pidfile still exists after stopping the service, wait
another second.

What I would like to do is to rely more on rc.subr to clean up the code a bit
more. By using $pidfile and perhaps $procname.

-- 
You are receiving this mail because:
You are the assignee for the bug.