[Bug 237215] games/diaspora: fix build with GCC-based architectures

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237215

--- Comment #1 from lightside <lightside at gmx.com> ---
Hello.

Thanks for PR and patch submission.

As I understood, the provided build log mentions about GCC 4.2.1 compiler:
_CCVERSION_921dbbb2=cc (GCC) 4.2.1 20070831 patched [FreeBSD] <..>

I checked build with using newer GCC 8.3 compiler (lang/gcc8, USE_GCC=yes) (at
least on amd64 architecture, but mentioned compiler errors might be the same)
and it builds without errors. The newer GCC 8.3 compiler doesn't require
CXXFLAGS+=-fpermissive for this case also. This may mean, that this is GCC
4.2.1 (or 4.x) related compiler issue.

The ".if exists(/usr/lib/libstdc++.so)" (in attachment #203608) is inderect
check for installed GCC 4.2.1 compiler in FreeBSD base, if I'm not wrong. There
are cases in current FreeBSD ports for such check. But maybe possible to add
some comment about GCC 4.2.1 related issue for this case.

I guess, that possible alternative approach is explicit check for GCC compiler
version, for example:
-8<--
USES+=  compiler

.include <bsd.port.pre.mk>

.if ${CHOSEN_COMPILER_TYPE} == gcc && ${COMPILER_VERSION} < 43
CXXFLAGS+=      -fpermissive
.endif

# <..>
.include <bsd.port.post.mk>
-->8-

(In reply to comment #0)
> While here, also add USES=gl.
You also proposed to add sdl to USES.

There is a space character between "+=" and "-fpermissive" on 76 (19 in patch)
line in attachment #203608: "WARN: Makefile: [76]: use a tab (not space) after
a variable name". Please fix this and I may approve this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.