[Bug 237132] devel/tcl-trf: crc-zlib broken

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237132

            Bug ID: 237132
           Summary: devel/tcl-trf: crc-zlib broken
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: regulaar at gmail.com
                CC: mi at ALDAN.algebra.com
                CC: mi at ALDAN.algebra.com
             Flags: maintainer-feedback?(mi at ALDAN.algebra.com)

crc-zlib is broken in devel/tcl-trf after port rev. 482639.

Proof:

% package require Trf
2.1.4
% set chk [crc-zlib {Hello, World!}]

% binary scan $chk i chksum
1
% format 0x%x $chksum
0x0

But we should get something different: https://wiki.tcl-lang.org/page/Trf

Apparently this is introduced in the following lines in patch-zlib:
190     -  CRC = zf.zcrc32 (CRC, buffer, bufLen);
191     +  CRC = crc32(0L, Z_NULL, 0);

No data are ever CRC'd here.

For Adler checksum things are better:
48      -  ADLER = zf.zadler32 (ADLER, buffer, bufLen);
49      +  ADLER = adler32 (ADLER, buffer, bufLen);

I hope no other filters are affected.

-- 
You are receiving this mail because:
You are the assignee for the bug.