[Bug 232785] mail/dovecot: does not identify config error and presents bad error message

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232785

            Bug ID: 232785
           Summary: mail/dovecot: does not identify config error and
                    presents bad error message
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: ler at FreeBSD.org
          Reporter: prj at rootwyrm.com
          Assignee: ler at FreeBSD.org
             Flags: maintainer-feedback?(ler at FreeBSD.org)

Created attachment 198737
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=198737&action=edit
mail_dovecot_files_dovecot.in.patch

If dovecot fails the configuration check, it will attempt to start anyways, and
present a misleading error message in the process.

Example of a config error attempting to start with the bad error message:

 root at draco /usr/local/etc/rc.d # ./dovecot onestart

usage: install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               [-B suffix] [-l linkflags] [-N dbdir]
               file1 file2
       install [-bCcpSsUv] [-f flags] [-g group] [-m mode] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               [-B suffix] [-l linkflags] [-N dbdir]
               file1 ... fileN directory
       install -dU [-vU] [-g group] [-m mode] [-N dbdir] [-o owner]
               [-M log] [-D dest] [-h hash] [-T tags]
               directory ...
./dovecot: WARNING: failed precmd routine for dovecot

Attached patch updates rc.d to perform the configuration check before
attempting to start, bails out if configuration check fails, and presents the
user with the exact error message from dovecot.

-- 
You are receiving this mail because:
You are the assignee for the bug.