[Bug 232267] [PATCH] mail/claws-mail-notification: fix stack corruption

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=232267

            Bug ID: 232267
           Summary: [PATCH] mail/claws-mail-notification: fix stack
                    corruption
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: joneum at FreeBSD.org
          Reporter: rozhuk.im at gmail.com
          Assignee: joneum at FreeBSD.org
             Flags: maintainer-feedback?(joneum at FreeBSD.org)

Created attachment 198158
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=198158&action=edit
patch

If app builded with: -fstack-protector-all -D_FORTIFY_SOURCE=2 -mretpoline
then on some html messages it crash with:
#0  0x0000000805c9acba in kill () from /lib/libc.so.7
#1  0x0000000805c9ac70 in __stack_chk_fail () from /lib/libc.so.7
#2  0x0000000805c9abe0 in __stack_chk_fail () from /lib/libc.so.7
#3  0x00000008190aba4a in notification_libnotify_sanitize_str () from
/usr/local/lib/claws-mail/plugins/notification.so
#4  0x00000008190ac0e7 in notification_popup_msg () from
/usr/local/lib/claws-mail/plugins/notification.so
#5  0x00000008190ab4ba in notification_new_unnotified_msgs () from
/usr/local/lib/claws-mail/plugins/notification.so
#6  0x00000008190aa6ee in plugin_init () from
/usr/local/lib/claws-mail/plugins/notification.so
#7  0x00000000005a9cdb in hooks_invoke ()
#8  0x0000000803b450f2 in g_hook_list_marshal () from
/usr/local/lib/libglib-2.0.so.0
#9  0x00000000005a9c5e in hooks_invoke ()
#10 0x000000000048da60 in folder_item_update_recursive ()
#11 0x0000000000486995 in folder_item_rename ()
#12 0x0000000803b63689 in g_node_traverse () from
/usr/local/lib/libglib-2.0.so.0
#13 0x0000000803b636af in g_node_traverse () from
/usr/local/lib/libglib-2.0.so.0
#14 0x0000000803b636af in g_node_traverse () from
/usr/local/lib/libglib-2.0.so.0
#15 0x0000000000488819 in folder_item_update_thaw ()
#16 0x00000000004ac026 in inc_pop_before_smtp ()
#17 0x00000000004aca5b in inc_all_account_mail ()
#18 0x00000000004ad8a6 in inc_autocheck_timer_init ()
#19 0x0000000803b5260b in g_list_sort_with_data () from
/usr/local/lib/libglib-2.0.so.0
#20 0x0000000803b56e48 in g_main_context_dispatch () from
/usr/local/lib/libglib-2.0.so.0
#21 0x0000000803b5722f in g_main_context_pending () from
/usr/local/lib/libglib-2.0.so.0
#22 0x0000000803b57305 in g_main_context_iteration () from
/usr/local/lib/libglib-2.0.so.0
#23 0x00000008013613a8 in gtk_main_iteration () from
/usr/local/lib/libgtk-x11-2.0.so.0
#24 0x00000000005a2105 in imap_threaded_connect ()
#25 0x00000000005a323b in imap_threaded_noop ()
---Type <return> to continue, or q <return> to quit--- 
#26 0x00000000004a7a36 in imap_utf8_to_modified_utf7 ()
#27 0x00000000004a7d81 in imap_utf8_to_modified_utf7 ()
#28 0x0000000803b5260b in g_list_sort_with_data () from
/usr/local/lib/libglib-2.0.so.0
#29 0x0000000803b56e48 in g_main_context_dispatch () from
/usr/local/lib/libglib-2.0.so.0
#30 0x0000000803b5722f in g_main_context_pending () from
/usr/local/lib/libglib-2.0.so.0
#31 0x0000000803b5765f in g_main_loop_run () from
/usr/local/lib/libglib-2.0.so.0
#32 0x000000080136117f in gtk_main () from /usr/local/lib/libgtk-x11-2.0.so.0
#33 0x00000000004b0473 in main ()

This is upstream backported path:
https://git.claws-mail.org/?p=claws.git;a=commit;h=87b362fc337957c73b9ce0d4f7321674693a30ad

And from me - increased temp buf size:
- gchar tmp_str[STR_MAX_LEN+1]
+ gchar tmp_str[STR_MAX_LEN+8]

-- 
You are receiving this mail because:
You are the assignee for the bug.