[Bug 231770] databases/sqlite3: Add ICU flavor

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=231770

Matt <fsbruva at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #197558|0                           |1
        is obsolete|                            |

--- Comment #3 from Matt <fsbruva at yahoo.com> ---
Created attachment 197729
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=197729&action=edit
Add flavors - default, icu and mini

I tested your patch tonight - and it behaved as I expected: users can de-select
the "ICU" option during `make config`. This is not appropriate.

I looked more closely at the Makefile for editors/emacs, and emulated the use
of OPTIONS_EXCLUDE to force the relevant build behavior for the icu and mini
flavors. While attempting that, I completely re-organized the Makefile to
conform to the guidance of [1], especially [2]. Following the major edit, I
audited the two versions to ensure I hadn't missed anything.

[1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html
[2]
https://www.freebsd.org/doc/en/books/porters-handbook/porting-order-options.html

-- 
You are receiving this mail because:
You are the assignee for the bug.