[Bug 233328] [NEW PORT}: lang/parser3: Simple and convenient object-oriented language

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233328

Nathan <ndowens at yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ndowens at yahoo.com

--- Comment #1 from Nathan <ndowens at yahoo.com> ---
Comment on attachment 199351
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=199351
Simple and convenient object-oriented language

OPTIONS_DEFAULT=        NGINX MYSQL SAFE_MODE XML
Should put right under OPTIONS_DEFINE and probably should move OPTIONS_DEFINE
and DEFAULT above _GROUPS

.if ${PORT_OPTIONS:MGMIME}
CONFIGURE_ARGS+=        --with-mailreceive
.endif
Can transform into:
GMIME_CONFIGURE_WITH= mailrecieve

X.if ! ${PORT_OPTIONS:MSAFE_MODE}
XCONFIGURE_ARGS+=       --disable-safe-mode
X.endif

To:
SAFE_MODE_CONFIGURE_ENABLE= safe-mode
(I know you set as default disabled, but as long as it is not in
OPTIONS_DEFAULT or user doesn't enable it, it will be disabled)

.if ${PORT_OPTIONS:MXML}
CONFIGURE_ARGS+=        --with-xml=${LOCALBASE}
.endif

To:
XML_CONFIGURE_WITH= xml=${LOCALBASE}

Try to use CONFIGURE_ENABLE or CONFIGURE_WITH instead of _ARGS or _ON
If you use _ON, you need to have an _OFF as well.
The single _WITH or _ENABLE correctly sets accordingly to weather something is
selected or not.

After changing the options, you can remove:
.include <bsd.port.options.mk>

the .if ${PORT_OPTIONS:} is the older style of OPTIONS, vs the newer way

-- 
You are receiving this mail because:
You are the assignee for the bug.