[Bug 233032] devel/subversion-book refuses to install; checks for unknown port option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=233032

            Bug ID: 233032
           Summary: devel/subversion-book refuses to install; checks for
                    unknown port option
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: lev at FreeBSD.org
          Reporter: pl at catslair.org
             Flags: maintainer-feedback?(lev at FreeBSD.org)
          Assignee: lev at FreeBSD.org

Created attachment 199016
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=199016&action=edit
A hopefully useful patch to remove the comparison

Hi there,

I'm trying to install devel/subversion-book but it fails while complaining that
the DOCS option is turned off globally and therefor it wouldn't make sense to
install the package:

peter at zefiris:/usr/ports/devel/subversion-book $ make build                    
 ===>  subversion-book-4515 it does not make sense to install dedicated        
  documentation if DOCS are globally disabled.                                 
   *** Error code 1                                                            
                                                                               
     Stop.                                                                     
      make: stopped in /usr/ports/devel/subversion-book      


At first I assumed it referred to the DOCS option in devel/subversion and I
really failed to understand the logic behind this; why would it matter if I had
build Subversion with documentation?

But looking into this matter a bit deeper seems to indicate that the Makefile
is actually checking for a non-existing port option:

peter at zefiris:/usr/ports/devel/subversion-book $ grep -A3 -i mdoc Makefile     
 .if !${PORT_OPTIONS:MDOCS}                                                    
  IGNORE= it does not make sense to install dedicated documentation if DOCS are
globally disabled                                                              
    .endif                                                                      

peter at zefiris:/usr/ports/devel/subversion-book $ make showconfig               
 ===> The following configuration options are available for
subversion-book-4515:      HTML_SINGLE=on: Single HTML page edition            
                            PDF=off: PDF edition                               
                        ===> Use 'make config' to modify these settings     


... therefor I think the whole comparison should be removed and that the port
should be able to build no matter what port option is or isn't turned on or
off. I tried to make a patch using diff and I hope this is useful (I'll be
honest: I didn't try to see if it worked).

-- 
You are receiving this mail because:
You are the assignee for the bug.