[Bug 228608] [NEW PORT] net/zmqpp: 0mq highlevel C++ bindings

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228608

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-qa
                 CC|                            |tobik at freebsd.org

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
XMASTER_SITES=  https://github.com/zeromq/zmqpp/archive/
XDISTNAME=      ${PORTVERSION}
[...]
XWRKSRC=                ${WRKDIR}/${PORTNAME}-${PORTVERSION}

This is bogus.  Please use USE_GITHUB and GH_ACCOUNT.  Then you
don't need to set WRKSRC and will automatically have a unique
distfile name.

Some other problems:

- Are you sure pathfix is needed?

- Why is patch-CMakeLists.txt needed?  Use CMAKE_OFF to turn off
  ZMQPP_BUILD_STATIC.

- It's building a shared library, so I highly doubt that NO_ARCH=yes
  is correct.

- The pkg-descr is too short.  Maybe include a general description of
  what zmq is or how zmqpp is different from cppzmq.

- Indentation in post-*: is off.  Only indent them with one tab.

- Either set PORTDOCS or include README.md in the plist but do not
  use both.

- Please provide some confirmation that this builds with Poudriere
  testport and passes portlint -AC.

-- 
You are receiving this mail because:
You are the assignee for the bug.