[Bug 228551] sysutils/restic: fails to install without bash and zsh option

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228551

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to w.schwarzenfeld from comment #1)
+.include <bsd.port.options.mk>
+
+.if ${PORT_OPTIONS:MZSH}
+PLIST_SUB+=    ZSH=""
+.else
+PLIST_SUB+=    ZSH="@comment "
+.endif
+
+.if ${PORT_OPTIONS:MBASH}
+PLIST_SUB+=    BASH=""
+.else
+PLIST_SUB+=    BASH="@comment "
+.endif
+

This is basically what OPTIONS_SUB=yes already does just more verbose and it's
not necessary.

But what we IMHO really should do here is remove the BASH and ZSH options
and always install the completion files like we recommend in the Porter's
Handbook.

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/shell-completion.html

-- 
You are receiving this mail because:
You are the assignee for the bug.