[Bug 228418] www/tomcat85: drop start_precmd from tomcat85.in

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228418

            Bug ID: 228418
           Summary: www/tomcat85: drop start_precmd from tomcat85.in
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: ports-bugs at FreeBSD.org
          Reporter: 1983-01-06 at gmx.net
                CC: vvd at unislabs.com
                CC: vvd at unislabs.com
             Flags: maintainer-feedback?(vvd at unislabs.com)

The start_precmd with the setenv.sh has no effect and shall be dropped for
these reasons:

1. It has been designed to be sourced by catalina.sh, we aren't using it. We
use jsvc (which could probably have been done with daemon(8))
2. None of the variables are available to the jsvc process when started with
service(8) verified with:

> @Override
> protected void doGet(HttpServletRequest req, HttpServletResponse resp)
> 		throws ServletException, IOException {
> 
> 	PrintWriter w = resp.getWriter();
> 
> 	for (Map.Entry<String, String> prop : System.getenv().entrySet()) {
> 		w.print(prop.getKey());
> 		w.print(" = ");
> 		w.println(prop.getValue());
> 	}
> 
> 	for (Map.Entry<Object, Object> prop : System.getProperties().entrySet()) {
> 		w.print(prop.getKey());
> 		w.print(" = ");
> 		w.println(prop.getValue());
> 	}
> 
> }

For service(8) it must be exported first, this isn't required by catalina.sh
and not documented by pkg-message.

At best, the start_precmd is dropped altogether. Users can always use
${name}_env to pass vars. This works for me.

This issue likely applies to all other Tomcat ports.

-- 
You are receiving this mail because:
You are the assignee for the bug.