[Bug 225924] [NEW PORT] dns/kadnode: P2P DNS resolver

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225924

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |Open
           Assignee|ports-bugs at FreeBSD.org      |tobik at freebsd.org

--- Comment #6 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to moritzwarning from comment #5)
Yes, everything the port installs should go under ${PREFIX} (which defaults to
/usr/local but users can set it to something else).

It already looks much better and I think it's close to being ok to commit.

XOPTIONS_DEFAULT= AUTH CMD LPD NSS

Move this just below OPTIONS_DEFINE.

X.if ${PORT_OPTIONS:MAUTH}
XFEATURES+=bob tls
XLIB_DEPENDS+=  libmbedtls.so:security/mbedtls
X.endif
X

As I said above, use options helpers instead.  This is described in detail in
the porter's handbook:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-options.html

For example the above should become

AUTH_LIB_DEPENDS=       libmbedtls.so:security/mbedtls
AUTH_VARS=      FEATURES+="bob tls"

XGH_TAGNAME=    v${PORTVERSION}

This works, but is not optimal.  Remove this and simply set

DISTVERSIONPREFIX=v

See
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex3

Please remove the ===== header and footer from pkg-descr.  I know that a lot
of ports add them but it doesn't really need them and it just adds to the
noise of `pkg install`.

-- 
You are receiving this mail because:
You are the assignee for the bug.