[Bug 228308] [NEW PORT] devel/kcov: ptrace-based coverage analyzer

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228308

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to Alan Somers from comment #1)
+BUILD_DEPENDS= binutils>=2.30:devel/binutils \
+               cmake:devel/cmake

cmake is redundant here because USES=cmake already adds it.

+PORTVERSION=   35.55.20180516
[...]
+# Use a GitHub tag until version 36 gets released, whenever that might be
+USE_GITHUB=    yes
+GH_ACCOUNT=    SimonKagstrom
+GH_PROJECT=    kcov
+GH_TAGNAME=    69dfa9c

The USE_GITHUB bits should go directly below the USES= line.

GH_PROJECT defaults to whatever PORTNAME is set to, so it's redundant
here.

Instead of setting GH_TAGNAME and inventing your own PORTVERSION try to
follow the procedure at [1] to derive a DISTVERSION{,SUFFIX,PREFIX}
triple. Only set GH_TAGNAME and PORTVERSION if that doesn't work.

In this case just set

DISTVERSIONPREFIX=      v
DISTVERSION=    35-57
DISTVERSIONSUFFIX=      -g69dfa9c

and remove PORTVERSION and GH_TAGNAME.

+USES=          cmake:outsource shebangfix python:build

Do the build scripts work with Python 3.x? If not you might have to
restrict the Python version here i.e. python:2.7,build.

+CMAKE_ARGS+=   -DKCOV_INSTALL_MANDIR=${PREFIX}/man

s/+=/=/

+python_CMD=    ${PYTHON_CMD}

Redundant.

+SHEBANG_REGEX= '.*\.py'

SHEBANG_GLOB=   *.py

+PORTDOCS=      COPYING \
+               COPYING.externals \
+               ChangeLog

If you use PORTDOCS the port must have a DOCS option.

OPTIONS_DEFINE= DOCS

Assuming that COPYING contains the license it should be installed via e.g.

LICENSE_FILE=   ${WRKSRC}/COPYING

instead.

[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5

-- 
You are receiving this mail because:
You are the assignee for the bug.