[Bug 228227] ports-mgmt/portlint: overeager "typically when you specify magic site you do not need anything else"

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228227

            Bug ID: 228227
           Summary: ports-mgmt/portlint: overeager "typically when you
                    specify magic site you do not need anything else"
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: marcus at FreeBSD.org
          Reporter: gerald at FreeBSD.org
             Flags: maintainer-feedback?(marcus at FreeBSD.org)
          Assignee: marcus at FreeBSD.org

This warning added in response to PR 225503 has proved useful in helping me
simplify gcc7, gcc6, and a couple of older GCC-related ports.

It is, however, overeager for several other cases, such as

  % cd $PORTSDIR/lang/gcc8-devel
  % portlint -C
  WARN: Makefile: typically when you specify magic site GCC you do not
  need anything else as releases/gcc-8-20180511 is assumed

This port has

  CATEGORIES=     lang
  MASTER_SITES=   GCC/snapshots/${DIST_VERSION}

whereas wh in Mk/bsd.sites.mk has

  GCC:releases/${DISTNAME} 


Would avoiding the warning when the first directory component of
MASTER_SITES is *not* part of what MASTER_SITES_ABBREVS be a good
heuristics?

(In this case that would be "snapshots" which is not part of
"releases/${DISTNAME}".)

-- 
You are receiving this mail because:
You are the assignee for the bug.