[Bug 218786] graphics/caffe2: [NEW PORT] Caffe2 is a lightweight, modular, and scalable deep learning framework

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218786

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #8 from Tobias Kortkamp <tobik at freebsd.org> ---
(In reply to Eric Camachat from comment #7)
If this is still relevant then this needs an update to a newer version and also
needs an update to work with Python flavors we have in the ports tree now.

Some quick review comments below:

+ZEROMQ_CMAKE_ON=       -DUSE_ZMQ=ON
+ZEROMQ_CMAKE_OFF=      -DUSE_ZMQ=OFF

could be

ZEROMQ_CMAKE_BOOL=      USE_ZMQ


+CMAKE_ARGS+=   -DUSE_NCCL=OFF -DUSE_CUDA=OFF -DUSE_NNPACK=OFF -DUSE_GLOO=OFF
-DBUILD_TEST=OFF

could be this now

CMAKE_OFF= USE_NCCL USE_CUDA USE_NNPACK USE_GLOO BUILD_TEST

+OPENMP_LLVMVER=        40

Would be good if this can be bumped to use LLVM 6.0 too.

+OPENMP_VARS_OFF=       USES+=compiler:c++11-lib

There's a _USES options helper, so this should be

OPENMP_USES=    compiler:c++11-lib

Same for CONFIGURE_ENV, MAKE_ENV

All the *_DESC options descriptions are in the wrong place.  To improve 
port readability they need to go into their own block just after
OPTIONS_SUB=yes.

+USES=          cmake python pkgconfig

If possible use cmake:outsource here.

-- 
You are receiving this mail because:
You are the assignee for the bug.