[Bug 228081] www/awstats: missing dep

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=228081

--- Comment #1 from Vidar Karlsen <vidar at karlsen.tech> ---
Thanks for spotting this! It might have passed under my radar as for some
reason it runs fine without p5-URI (and p5-Encode) in my environments, even in
a minimal test jail with an nginx access log I copied from somewhere else:

root at fbsd11-1-portswrk:~ # pkg info
awstats-7.7,1                  Free real-time logfile analyzer to get advanced
web statistics
p5-Digest-HMAC-1.03_1          Perl5 interface to HMAC Message-Digest
Algorithms
p5-Net-DNS-1.15,1              Perl5 interface to the DNS resolver, and dynamic
updates
p5-Net-IP-1.26_1               Perl extension for manipulating IPv4/IPv6
addresses
p5-Net-XWhois-0.90_5           Whois Client Interface for Perl5
perl5-5.26.2                   Practical Extraction and Report Language
pkg-1.10.5                     Package manager

root at fbsd11-1-portswrk:~ # grep ^LoadPlugin
/usr/local/etc/awstats/awstats.entropia.no.conf
LoadPlugin="decodeutfkeys"

root at fbsd11-1-portswrk:~ # /usr/local/www/awstats/cgi-bin/awstats.pl
-config=entropia.no
Create/Update database for config
"/usr/local/etc/awstats/awstats.entropia.no.conf" by AWStats version 7.7 (build
20180105)
>From data in log file "/usr/local/etc/awstats/entropia.no.access.log"...
Phase 1 : First bypass old records, searching new record...
Searching new records from beginning of log file...
Phase 2 : Now process new records (Flush history on disk after 20000 hosts)...
Jumped lines in file: 0
Parsed lines in file: 13877
 Found 3077 dropped records,
 Found 0 comments,
 Found 0 blank records,
 Found 4 corrupted records,
 Found 0 old records,
 Found 10796 new qualified records.



I can't seem to recreate the problem on my end, but the DecodeUTFKeys plugin
does say it requires Encode and URI::Escape.

These plugins are however not enabled by default, and adding p5-URI as a rundep
will only solve it for the DecodeUTFKeys plugin. Looking at the other bundled
plugins, I see several more requirements, and I'm thinking of adding them as
options with some suitable descriptions (e.g. "p5-URI, required by the
DecodeUTFKeys plugin"). Do you have any thoughts on that?

Full list of plugins with requirements:
$ grep -B2 "REQUIRED MODULES:"
/usr/local/www/awstats/cgi-bin/awstats.model.conf

# PLUGIN: DecodeUTFKeys
# REQUIRED MODULES: Encode and URI::Escape
--
# PLUGIN: IPv6
# PARAMETERS: None
# REQUIRED MODULES: Net::IP and Net::DNS
--
# PLUGIN: HashFiles
# REQUIRED MODULES: Storable
--

# PLUGIN: HostInfo
# REQUIRED MODULES: Net::XWhois
--

# PLUGIN: TimeHiRes
# REQUIRED MODULES: Time::HiRes (if Perl < 5.8)
--

# PLUGIN: TimeZone
# REQUIRED MODULES: Time::Local
--

# PLUGIN: GeoIPfree
# REQUIRED MODULES: Geo::IPfree version 0.2+ (from Graciliano M.P.)
--

# PLUGIN: GeoIP
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)
--

# PLUGIN: GeoIP6
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind, version >=
1.40)
--

# PLUGIN: GeoIP_City_Maxmind
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)
--

# PLUGIN: GeoIP_ASN_Maxmind
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)
--

# PLUGIN: GeoIP_Region_Maxmind
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)
--

# PLUGIN: GeoIP_ISP_Maxmind
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)
--

# PLUGIN: GeoIP_Org_Maxmind
# REQUIRED MODULES: Geo::IP or Geo::IP::PurePerl (from Maxmind)

-- 
You are receiving this mail because:
You are the assignee for the bug.