[Bug 226809] lang/ccl: Include <machine/trap.h> explicitly

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Tue Mar 20 22:12:45 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226809

            Bug ID: 226809
           Summary: lang/ccl: Include <machine/trap.h> explicitly
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: olgeni at FreeBSD.org
          Reporter: jhb at FreeBSD.org
          Assignee: olgeni at FreeBSD.org
             Flags: maintainer-feedback?(olgeni at FreeBSD.org)

Created attachment 191673
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=191673&action=edit
trap.patch

A pending change I have for src will remove the nested include of
<machine/trap.h> from <machine/signal.h>.  As a result, the ccl port needs to
include <machine/trap.h> explicitly for access to T_PAGEFLT.

While here, I noticed that the port was also checking the wrong field for a
flag indicating if the AVX state in an mcontext_t is valid.  The flags are
saved in 'mc_flags', not 'mc_trapno'.  The code might have been wrong due to a
misleading comment I just fixed yesterday in head (the command claimed the flag
bits applied to mc_trapno rather than mc_flags).

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the freebsd-ports-bugs mailing list