[Bug 226661] lang/smlnj: Use current SIGFPE signal codes

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=226661

Johannes 5 <joemann at beefree.free.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(joeman |maintainer-feedback+
                   |n at beefree.free.de)          |

--- Comment #1 from Johannes 5 <joemann at beefree.free.de> ---
(In reply to John Baldwin from comment #0)
> sigfpe.patch
> I have a pending patch for src/ that removes deprecated signal code
> values (first deprecated in 1999). [...]
> The src change can be found here:
> https://reviews.freebsd.org/D14637

Thank you for noticing and fixing this issue with lang/smlnj.

> FreeBSD adopted standard siginfo codes consistent with POSIX starting
> in 7.0 release. [...]
> The attached patch changes it to use the modern
> constants instead. Both old and new constants have the same value, so
> this should not be a runtime change.

Then I can't see a reason, why this port should block the cleanup of
src any further. (The FPE_*_TRAP macros should be removed upstream as
well. Hopefully, I'll remember to report this after an update of the
port to 110.82. There's a patch for this update [1], but it's not tested
on i386, hence not yet submitted:-(

> During an exa-run, smlnj failed to build as it is still using the
> older constants. [...]

I assume, that your sigfpe.patch makes the port compile on -CURRENT,
right? I briefly checked it on 11.1-STABLE amd64, and it continues to
compile and work, as expected.

So I suggest that you commit your patch to lang/smlnj and unblock
226579. If there's anything else I should do, please let me know.

Thanx!
Johannes

[1] <ftp://offshore.free.de/pub/patch/smlnj.patch.20180105>

-- 
You are receiving this mail because:
You are the assignee for the bug.