[Bug 217706] [New port] shells/zsh-antigen: A plugin manager for the Z shell, inspired by Vundle

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217706

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #6 from Tobias Kortkamp <tobik at freebsd.org> ---
Sorry that it took more than a year to get any feedback on your submission!
Here are a couple of points that need to be fixed to get it into the ports
tree.

- The indentation is off.  Please remove one tab from each variable.
  Not everything has to be aligned to DISTVERSIONPREFIX.

Xdo-build:
X       # empty

NO_BUILD=       yes

XPORTNAME=              zsh-antigen
XGH_PROJECT=            antigen

Use this instead

PORTNAME=       antigen
PKGNAMEPREFIX=  zsh-

Xdo-extract:
X       ${TAR} -C ${WRKDIR} -xf ${DISTDIR}/${DISTNAME}${EXTRACT_SUFX}
X       ${CP} ${WRKDIR}/${GH_PROJECT}-${PORTVERSION}/bin/antigen.zsh
${WRKDIR}/${GH_PROJECT}-${PORTVERSION}/LICENSE ${WRKDIR}
X       ${RM} -r ${WRKDIR}/${GH_PROJECT}-${PORTVERSION}

Remove.  You can install things directly from ${WRKSRC}.

- Remove pkg-message. You already have pkg-message.in

- Variable order is slightly wrong. See
  https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

- Update to the newest version please.  I don't think it makes sense to add
  a one year old version of antigen to the ports tree.

- Please confirm that this passes portlint and Poudriere testport.

-- 
You are receiving this mail because:
You are the assignee for the bug.