[Bug 227109] Mk/Scripts, cleanup using devel/hs-ShellCheck

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jun 1 16:22:09 UTC 2018


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227109

--- Comment #16 from commit-hook at freebsd.org ---
A commit references this bug:

Author: mat
Date: Fri Jun  1 16:20:51 UTC 2018
New revision: 471273
URL: https://svnweb.freebsd.org/changeset/ports/471273

Log:
  SC2155: Declare and assign separately to avoid masking return values.

  In the original code, the return value of mycmd is ignored, and export
  will instead always return true. This may prevent conditionals, set -e
  and traps from working correctly.

  PR:           227109
  Submitted by: mat
  Sponsored by: Absolight

Changes:
  head/Mk/Scripts/smart_makepatch.sh

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list