[Bug 230179] textproc/luaexpat: fails test script on lua 5.3

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230179

            Bug ID: 230179
           Summary: textproc/luaexpat: fails test script on lua 5.3
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: lx at FreeBSD.org
          Reporter: andrew at tao11.riddles.org.uk
             Flags: maintainer-feedback?(lx at FreeBSD.org)
          Assignee: lx at FreeBSD.org

Created attachment 195622
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195622&action=edit
Makefile patch

The supposed "fix" for luaexpat in
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224644 is incorrect, and this
is easily demonstrated by running the test.lua script included in the module
source.

The most reasonable fix seems to be this (in addition to removing the incorrect
LUA_32BITS):

MAKE_ARGS+= COMMON_CFLAGS="-Wall"

(i.e. removing options -g -O2 -ansi -pedantic -fPIC -DPIC from the makefile;
-fPIC is added back from CFLAGS already, and debug/optimization flags are
likewise supposed to come from the port CFLAGS.)

Another option that works would be to use -std=c99, but I think the above
method is better (and I have checked that the test script runs ok on lua 5.1
and 5.2 still).

Patch attached. (I also added a LICENSE=MIT - see the doc/us/license.html in
the distribution)

-- 
You are receiving this mail because:
You are the assignee for the bug.