[Bug 234508] sysutils/grub2: Update to recent snapshot, fix build with GCC 8

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=234508

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch, needs-qa
            Summary|new port: sysutils/grub2    |sysutils/grub2: Update to
                   |replacement                 |recent snapshot, fix build
                   |                            |with GCC 8
             Status|New                         |Open

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Please make this a unified diff against the existing port.  It's
harder to see what you changed otherwise.

It would also be good to base this on a recent revision (at least
the changes and fixes from ports 484145 and ports r488585 appear
to not be included here).

X               ${LOCALBASE}/bin/strip:devel/binutils \
X               ${LOCALBASE}/bin/gcc8:lang/gcc8

These changes are wrong and ignore GCC_DEFAULT and other settings.
Please use USE_GCC.  If it doesn't need gcc at runtime, add

RUN_DEPENDS:=   ${RUN_DEPENDS:Ngcc*}

after .include <bsd.port.mk>

X               ${LOCALBASE}/bin/python:lang/python

Depending on the lang/python is forbidden by policy.  People went
through great pains to remove it from all ports, use

BINARY_ALIAS=   python=${PYTHON_CMD}

if the build calls python directly.

XICONV_PREFIX=  ${LOCALBASE}

ICONV_PREFIX is not a port settable variable and should only be set
by the framework.  It also already set by USES=iconv

XMAKE_CMD=      ${LOCALBASE}/bin/gmake

Already set by USES=gmake

X# Created by: bergerkos at yahoo.co.uk

Please retain the original "Created by" line.  You did not create
this port, sem@ did.  You'll get full credit for the update in the
commit log.

Xpre-configure:
X       @cd ${WRKSRC} && ${SH} autogen.sh
X

Why does USES=autoreconf no longer suffice?

-- 
You are receiving this mail because:
You are the assignee for the bug.