[Bug 219921] multimedia/libxine: update to version 1.2.9

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=219921

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #190848|0                           |1
        is obsolete|                            |
                 CC|                            |tobik at freebsd.org

--- Comment #7 from Tobias Kortkamp <tobik at freebsd.org> ---
Created attachment 196428
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=196428&action=edit
libxine.diff (rebase of previous patch; still broken)

> Patch doesn't apply cleanly.

Only the PORT{VER,REVI}SION hunk doesn't apply which is trivial to
fix and about what one would expect given the age of the patch.
files/patch-ffmpeg4 needs to be deleted too (part of libxine now).

I'm more worried about the changes in pkg-plist like dropping the
%%NLS%%, %%ESOUND%%, %%JACK%% and various other options prefixes,
and the bogus %%DATADIR%%-lib, etc.  Clearly this patch has not
been thoroughly tested with regards to options and in its current
state would require significant time investment by a committer
before committing it.

To be clear: I'm attaching a rebased patch, but I have not fixed
any of the problems.

> Also patches should be created in ports base dir, per porters
> handbook.

Hmm, the patch format and base is ok and seems to be pretty
much created as described here:

https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html#svn-diff

-- 
You are receiving this mail because:
You are the assignee for the bug.