[Bug 230354] emulators/libdsk: Update to 1.4.2

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230354

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #3 from Tobias Kortkamp <tobik at freebsd.org> ---
Comment on attachment 195847
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195847
Update

+.for i in ${DOCS}
+               ${INSTALL_DATA} ${WRKSRC}/doc/${i} ${STAGEDIR}${DOCSDIR}
+.endfor

More readable and better since it runs ${INSTALL_DATA} only once:

cd ${WRKSRC}/doc && ${INSTALL_DATA} ${DOCS} ${STAGEDIR}${DOCSDIR}

+DOCS=          apridisk.html cfi.html libdsk.lyx libdsk.pdf \
+               libdsk.txt libdskrc.sample protocol.txt README TODO

Just use PORTDOCS here instead and remove the PLIST_FILES bit below
again.

+.if ${PORT_OPTIONS:MDOCS}
+PLIST_FILES+=  ${PORTDOCS}${DOCSDIR}/README ${PORTDOCS}${DOCSDIR}/TODO \
+               ${PORTDOCS}${DOCSDIR}/apridisk.html
${PORTDOCS}${DOCSDIR}/cfi.html \
+               ${PORTDOCS}${DOCSDIR}/libdsk.lyx
${PORTDOCS}${DOCSDIR}/libdsk.pdf \
+               ${PORTDOCS}${DOCSDIR}/libdsk.txt
${PORTDOCS}${DOCSDIR}/libdskrc.sample \
+               ${PORTDOCS}${DOCSDIR}/protocol.txt
+.endif

This is not necessary when using PORTDOCS, but you should read up
on options helpers variables either way [1].

Variables should always be set before any targets [2].

[1]
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-options.html#options-variables
[2] https://www.freebsd.org/doc/en/books/porters-handbook/porting-order.html

-- 
You are receiving this mail because:
You are the assignee for the bug.