[Bug 230362] net/csocks: Update to 1.7

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230362

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org

--- Comment #5 from Tobias Kortkamp <tobik at freebsd.org> ---
Comment on attachment 195859
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=195859
Update

+USES=          compiler:gcc-c++11-lib

Does it not build with Clang anymore?  Why does it require GCC now?
Forcing GCC usage in a port should be a last resort.

-       ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib
-       ${LN} -s libcsocks.so.1 ${STAGEDIR}${PREFIX}/lib/libcsocks.so
+       ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1
${STAGEDIR}${PREFIX}/lib/libcsocks.so.1
+       ${INSTALL_LIB} ${WRKDIR}/src/libcsocks.so.1
${STAGEDIR}${PREFIX}/lib/libcsocks.so

This is a bogus change.  You're now installing libcsocks.so.1 twice
(so the package will take twice the space).  libcsocks.so should be a symlink.
Please revert this.

--- net/csocks/files/patch-csocks.c     (nonexistent)
+++ net/csocks/files/patch-csocks.c     (working copy)

net/csocks/files/patch-csocks.c looks fishy.  Why is it needed and why
does it remove a bunch of NULL checks?

-- 
You are receiving this mail because:
You are the assignee for the bug.