[Bug 227105] x11-wm/bspwm: update to 0.9.5

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227105

Guido Falsi <madpilot at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |madpilot at FreeBSD.org

--- Comment #5 from Guido Falsi <madpilot at FreeBSD.org> ---
There are still a few problems with this submission.

If the CONTRIB option is turned on you install extra files, which are not
listed in the plist.

You should go back to external pkg-plist files and use plist substitutions
depending on options. This is documented here:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist.html#plist-sub

This is required otherwise the extra files will be simply left in the staging
directory and never included in the actual package installed on the system.


Also, this is more of an opinion, but fixing the upstream provided install
target is preferred to rolling out your own do-install in the port Makefile.

-- 
You are receiving this mail because:
You are the assignee for the bug.