[Bug 227155] [NEW PORT] databases/py-carbonate: Tools for managing federated carbon clusters

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227155

Kubilay Kocak <koobs at FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |needs-patch

--- Comment #5 from Kubilay Kocak <koobs at FreeBSD.org> ---
A few review items:

/usr/local should never be hardcoded. In this case, since we cant pass it as a
configuration to the build, use %%PREFIX%% in the patch, and then use
REINPLACE_CMD to replace it with the current ${PREFIX} value at post-patch. [1]

Either add a comment above the commented out LICENSE_FILE to explain it ('not
yet packaged with distfile'), or leave the line out. Without a comment it looks
accidental.

Since the python package installs console scripts (things into localbase/bin)
[2], make the port concurrent versions safe by using USE_PYTHON=concurrent,
which will automatically version suffix all scripts and create (version-less)
symlinks to point the versioned scriptnames. This isn't a major issue as the
port currently only supports 2.7, but the port should be made concurrent safe
anyway.

Add comments to patches, in particular for ones that aren't self explanatory.
In this case the patch that adds 'ROUTER_HASH_TYPE = None'. You (awesomely)
explained (most?) of them in your initial comment 0, add those comments and
references to the top of all the patches themselves.

[1] See: 4.4.3. Simple Automatic Replacements in Porters Handbook
[2] https://github.com/graphite-project/carbonate/blob/master/setup.py#L37

-- 
You are receiving this mail because:
You are the assignee for the bug.