[Bug 216499] [new port] audio/eq10q: Set of mono and stereo parametric equalizers

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216499

Yuri Victorovich <yuri at rawbw.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |yuri at rawbw.com

--- Comment #3 from Yuri Victorovich <yuri at rawbw.com> ---
Hi Goran,

I accidentally submitted another version of the same package (bug#222113) among
many other LV2 plugins, because I didn't notice your port submission.

Your port has several issues:
* It lacks -lv2 suffix
* It uses patches under files/ when it's preferred to patch from Makefile when
possible (one-liners like these)
* It doesn't take advantage of USES for gtkmm, etc which is required
* It has a redundant RUN_DEPENDS on Jack, when LV2 plugins don't normally
depend on Jack
* It fails to build in 10.X because it keeps -finline-functions-called-once
which isn't supported there
* It doesn't remove -O3 from Makefiles, so it's impossible to debug if needed

I am not insisting, but do you mind dropping your submission in favor of
bug#222113 because it is already free of these problems?
Alternatively, you can fix them, or just copy bug#222113 over, and I will then
drop bug#222113?
Either way, but only one should be left to make the work of the committer
easier.

Thanks!
Yuri

-- 
You are receiving this mail because:
You are the assignee for the bug.