[Bug 222122] mail/opendkim rc script needs default for $milteropendkim_socket

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222122

            Bug ID: 222122
           Summary: mail/opendkim rc script needs default for
                    $milteropendkim_socket
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: thomas at gibfest.dk
                CC: freebsd-ports at dan.me.uk
             Flags: maintainer-feedback?(freebsd-ports at dan.me.uk)
                CC: freebsd-ports at dan.me.uk

Since ports r448274 the rc.d script for milter-opendkim outputs an error when I
do not have $milteropendkim_socket set in rc.conf but have it set in the config
file. The latest change to the rc.d script appears to assume that
$milteropendkim_socket is always set.

I think a default is needed or the test in line 77 needs to check if anything
is in the $milteropendkim_socket variable. test(1) returns true (exit code 0)
when given no args.

Below is the output from starting milter-opendkim without setting
$milteropendkim_socket in rc.conf with rc_debug enabled:

[tsr at smtp2 ~]$ sudo service milter-opendkim start
/usr/local/etc/rc.d/milter-opendkim: DEBUG: pid file
(/var/run/milteropendkim/pid): not readable.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: checkyesno: milteropendkim_enable
is set to yes.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_precmd:
dkim_prepcmd 
Starting milteropendkim.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: doit:  limits -C
daemon /usr/local/sbin/opendkim  -l   -u postfix:mailnull -P
/var/run/milteropendkim/pid -x /usr/local/etc/opendkim.conf    
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_postcmd:
dkim_start_postcmd 
usage: chmod [-fhv] [-R [-H | -L | -P]] mode file ...
[tsr at smtp2 ~]$ 

Below is the output from starting milter-opendkim with $milteropendkim_socket
set in rc.conf with rc_debug enabled:

[tsr at smtp2 ~]$ sudo service milter-opendkim start
/usr/local/etc/rc.d/milter-opendkim: DEBUG: pid file
(/var/run/milteropendkim/pid): not readable.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: checkyesno: milteropendkim_enable
is set to yes.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_precmd:
dkim_prepcmd 
Starting milteropendkim.
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: doit:  limits -C
daemon /usr/local/sbin/opendkim  -l -p
local:/var/spool/postfix/opendkim/opendkim.sock -u postfix:mailnull -P
/var/run/milteropendkim/pid -x /usr/local/etc/opendkim.conf    
/usr/local/etc/rc.d/milter-opendkim: DEBUG: run_rc_command: start_postcmd:
dkim_start_postcmd 
[tsr at smtp2 ~]$

-- 
You are receiving this mail because:
You are the assignee for the bug.