[Bug 220540] New port: shells/resh Restricted shell that only allows previously defined commands

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220540

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tobik at freebsd.org
           Assignee|freebsd-ports-bugs at FreeBSD. |tobik at freebsd.org
                   |org                         |
             Status|New                         |Open

--- Comment #1 from Tobias Kortkamp <tobik at freebsd.org> ---
Thanks for your submission.  It looks mostly good to me, but I have a couple of
nitpicks you'd need to address before I can commit it:

XPORTVERSION=   0.1.2
XGH_TAGNAME=    186907

Tag v0.1.2 in the upstream repo is for commit c1ec9c8 not 186907.  Please do
not
invent version numbers that have no correspondence with upstream versions.  If
you need to use a later commit than v0.1.2 for some reason then follow the
procedure from [1].

XLICENSE=       MIT

Please also set LICENSE_FILE since the upstream repo has one.

XPLIST_FILES=   bin/resh

Since resh is a shell please create a pkg-plist file with

@shell bin/resh

instead.  That will create an entry in /etc/shells on install [2].

[1]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-ex5
[2]
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/plist-keywords.html#plist-keywords-shell

-- 
You are receiving this mail because:
You are the assignee for the bug.