[Bug 223688] lang/luajit: Ensure the .strtab section written by bcsave.lua is the correct size

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223688

            Bug ID: 223688
           Summary: lang/luajit: Ensure the .strtab section written by
                    bcsave.lua is the correct size
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: osa at FreeBSD.org
          Reporter: dim at FreeBSD.org
          Assignee: osa at FreeBSD.org
             Flags: maintainer-feedback?(osa at FreeBSD.org)

Created attachment 188029
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=188029&action=edit
Fix lang/luajit object file .strtab size

When luajit writes a ELF object file (using the -b option), it sets the size of
the .strtab section one byte too short.  In function bcsave_elfobj(), the
offset of the .rodata section after .strtab is already calculated correctly,
but the size of .strtab itself is one byte too small.  Even though there is a
zero byte after the last string in the table, the short size causes lld (the
LLVM linker) to show an error message similar to:

ld: error: obj/bytecode.o: string table non-null terminated

See also https://github.com/LuaJIT/LuaJIT/pull/366, and bug 214864
(specifically the benchmarks/wrk failure).

-- 
You are receiving this mail because:
You are the assignee for the bug.