[Bug 218194] Mk/Uses/go.mk uses ${LOCALBASE} instead of ${PREFIX} in do-install target

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218194

            Bug ID: 218194
           Summary: Mk/Uses/go.mk uses ${LOCALBASE} instead of ${PREFIX}
                    in do-install target
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: aduitsis at douitsis.com
                CC: freebsd-ports-bugs at FreeBSD.org

(Apologies if I have figured something wrong in this)

In Mk/Uses/go.mk do-install target, line 88 says:

        ${INSTALL_PROGRAM} ${GO_WRKDIR_BIN}/${_TARGET:T}
{STAGEDIR}/${LOCALBASE}/bin; \

In many cases, one wants to install in different places than ${LOCALBASE},
which if left unchanged will default to /usr/local. 

Example 1 is when running "port test", which will try to set ${PREFIX}
directly, but leave ${LOCALBASE} untouched. So, running 'port test' in a
USES=go port and with the default do-install target will cause failure during
the install phase.

Example 2 is running 'make clean; make package PREFIX=/var/tmp/`make -V
PORTNAME`', as suggested in
https://www.freebsd.org/doc/en/books/porters-handbook/porting-prefix.html.
Again, changing ${PREFIX} does not change the install location which is still
/usr/local and the make package command fails.

I respectfully submit that perhaps ${LOCALBASE} should be changed to ${PREFIX}.

-- 
You are receiving this mail because:
You are on the CC list for the bug.