[Bug 218029] Scripts/do-depends.sh: fix output list of dependencies "not satisfied in the XYZ phase" in error message

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218029

--- Comment #2 from Andreas Sommer <andreas.sommer87 at googlemail.com> ---
Well, it simply adds an output line saying which patterns were unsatisfied. I
guess that in 99% of port developers' cases, this simply never happens. In my
example, I had a custom setup (poudriere with own changes) which led to these
dependency errors:

Without patch:

> =======================<phase: test           >============================
> ===>  Staging for hhdate-2.1.0
> ===>   Generating temporary packing list
> install  -m 0644 /wrkdirs/usr/ports/devel/hhdate/work/date-d110f07f596d86e63daa2db41f1d52c05f4a179c/date.h /wrkdirs/usr/ports/devel/hhdate/work/stage/usr/local/include/
> ====> Compressing man pages (compress-man)
> ===>  Testing for hhdate-2.1.0
> ===>   hhdate-2.1.0 depends on file: /usr/local/bin/clang39 - not found
> ===>   Installing existing package /packages/All/llvm39-3.9.1_2.txz
> [porttesting-devel] Installing llvm39-3.9.1_2...
> [porttesting-devel] `-- Installing libxml2-2.9.4...
> [porttesting-devel] `-- Extracting libxml2-2.9.4: .......... done
> [porttesting-devel] Extracting llvm39-3.9.1_2: .......... done
> ===>   hhdate-2.1.0 depends on file: /usr/local/bin/clang39 - found
> ===>   Returning to build of hhdate-2.1.0
> ===>   dp_STRICT_DEPENDS set - Not installing missing dependencies.
>        This means a dependency is wrong since it was not satisfied in the TEST_DEPENDS phase.
> *** Error code 1

With patch:

> =======================<phase: test           >============================
> ===>  Staging for hhdate-2.1.0
> ===>   Generating temporary packing list
> install  -m 0644 /wrkdirs/usr/ports/devel/hhdate/work/date-d110f07f596d86e63daa2db41f1d52c05f4a179c/date.h /wrkdirs/usr/ports/devel/hhdate/work/stage/usr/local/include/hhdate/
> ====> Compressing man pages (compress-man)
> ===>  Testing for hhdate-2.1.0
> ===>   hhdate-2.1.0 depends on file: /usr/local/bin/clang39 - not found
> ===>   Installing existing package /packages/All/llvm39-3.9.1_2.txz
> [porttesting-devel] Installing llvm39-3.9.1_2...
> [porttesting-devel] `-- Installing libxml2-2.9.4...
> [porttesting-devel] `-- Extracting libxml2-2.9.4: .......... done
> [porttesting-devel] Extracting llvm39-3.9.1_2: .......... done
> ===>   hhdate-2.1.0 depends on file: /usr/local/bin/clang39 - found
> ===>   Returning to build of hhdate-2.1.0
> ===>   dp_STRICT_DEPENDS set - Not installing missing dependencies.
>        This means a dependency is wrong since it was not satisfied in the TEST_DEPENDS phase.
>        List of not found patterns: /usr/local/bin/clang39
> *** Error code 1

I believe the output is helpful because if something catastrophic like that
happens, you want verbose output of what exactly wasn't satisfied (there could
be many patterns defined).

-- 
You are receiving this mail because:
You are on the CC list for the bug.