[Bug 217872] [NEW PORT] graphics/guetzli: Perceptual JPEG encoder

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=217872

Tobias Kortkamp <tobik at freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|freebsd-ports-bugs at FreeBSD. |tobik at freebsd.org
                   |org                         |
             Status|New                         |Open
                 CC|                            |tobik at freebsd.org

--- Comment #2 from Tobias Kortkamp <tobik at freebsd.org> ---
Hi Yuri,

some comments inline.

X# Created by: Yuri Victorovich <yuri at rawbw.com>
X# $FreeBSD$
X
XPORTNAME=      guetzli
XPORTVERSION=   0.170317

Version 1.0 is tagged on GitHub.  Why can't we use it?

XDISTVERSIONPREFIX=     v

DISTVERSIONPREFIX is unnecessary if you're not using the
v1.0 tag.

XCATEGORIES=    graphics
X
XMAINTAINER=    yuri at rawbw.com
XCOMMENT=       Perceptual JPEG encoder
X
XLICENSE=       APACHE20

Missing LICENSE_FILE

X
XLIB_DEPENDS=   libpng.so:graphics/png \
X               libgflags_nothreads.so:devel/gflags
X
XUSE_GITHUB=    yes
XGH_ACCOUNT=    google
XGH_TAGNAME=    b0cf821
X
XUSES=          gmake
XCFLAGS+=       -I${LOCALBASE}/include
XLDFLAGS+=      -L${LOCALBASE}/lib

Remove CFLAGS and LDFLAGS and add USES=localbase:ldflags

XPLIST_FILES=   bin/guetzli
X
Xdo-install:
X       ${INSTALL_PROGRAM} ${WRKSRC}/bin/Release/guetzli
${STAGEDIR}${PREFIX}/bin
X
X.include <bsd.port.mk>

The build seems to not be verbose.  I suggest adding MAKE_FLAGS= verbose=1 to
make future build failure logs more informative.

This also reveals that -O3 is passed to the build where it shouldn't be.
Maybe also add config=debug to MAKE_FLAGS.

-- 
You are receiving this mail because:
You are the assignee for the bug.