[Bug 220189] x11-toolkits/mygui: stop redefining nullptr

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220189

            Bug ID: 220189
           Summary: x11-toolkits/mygui: stop redefining nullptr
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Some People
          Priority: ---
         Component: Individual Port(s)
          Assignee: amdmi3 at FreeBSD.org
          Reporter: dim at FreeBSD.org
          Assignee: amdmi3 at FreeBSD.org
             Flags: maintainer-feedback?(amdmi3 at FreeBSD.org)

Created attachment 183680
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=183680&action=edit
Stop redefining nullptr

During an exp-run for the projects/clang500-import branch (bug 219139), it
turned out that x11-toolkits/mygui does not build against libc++ 5.0.0 [1]:

In file included from
/wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.2.2/MyGUIEngine/src/MyGUI_ActionController.cpp:7:
In file included from
/wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.2.2/MyGUIEngine/include/MyGUI_Precompiled.h:11:
In file included from
/wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.2.2/MyGUIEngine/include/MyGUI_Common.h:12:
In file included from /usr/include/c++/v1/string:470:
In file included from /usr/include/c++/v1/string_view:170:
In file included from /usr/include/c++/v1/__string:56:
In file included from /usr/include/c++/v1/algorithm:640:
/usr/include/c++/v1/memory:2089:9: error: cannot initialize a member subobject
of type 'std::__1::basic_string<char> *' with an rvalue of type 'int'
      : __value_(_VSTD::forward<_Up>(__u)){};
        ^        ~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/v1/memory:2174:9: note: in instantiation of function template
specialization 'std::__1::__compressed_pair_elem<std::__1::basic_string<char>
*, 0, false>::__compressed_pair_elem<int, void>' requested here
      : _Base1(std::forward<_Tp>(__t)), _Base2() {}
        ^
/usr/include/c++/v1/vector:428:7: note: in instantiation of function template
specialization 'std::__1::__compressed_pair<std::__1::basic_string<char> *,
std::__1::allocator<std::__1::basic_string<char> > >::__compressed_pair<int,
true>' requested here
      __end_cap_(nullptr)
      ^
/usr/include/c++/v1/vector:478:5: note: in instantiation of member function
'std::__1::__vector_base<std::__1::basic_string<char>,
std::__1::allocator<std::__1::basic_string<char> > >::__vector_base' requested
here
    vector()
_NOEXCEPT_(is_nothrow_default_constructible<allocator_type>::value)
    ^
/wrkdirs/usr/ports/x11-toolkits/mygui/work/mygui-MyGUI3.2.2/MyGUIEngine/include/MyGUI_StringUtility.h:293:29:
note: in instantiation of member function
'std::__1::vector<std::__1::basic_string<char>,
std::__1::allocator<std::__1::basic_string<char> > >::vector' requested here
                        std::vector<std::string> result;
                                                 ^

These errors are because mygui by default redefines 'nullptr' to 0, even while
it is being compiled as C++11.  This is not supported.  Luckily it supports a
define MYGUI_DONT_REPLACE_NULLPTR to stop doing that.

(I don't know why the port is compiled with C++11 though, it does not seem to
be necessary.)

[1]
http://package18.nyi.freebsd.org/data/headamd64PR219139-default/2017-05-22_13h01m42s/logs/errors/mygui-3.2.2_2.log

-- 
You are receiving this mail because:
You are the assignee for the bug.