[Bug 220983] www/node is incorrectly patching common.gypi

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220983

            Bug ID: 220983
           Summary: www/node is incorrectly patching common.gypi
           Product: Ports & Packages
           Version: Latest
          Hardware: amd64
                OS: Any
            Status: New
          Severity: Affects Many People
          Priority: ---
         Component: Individual Port(s)
          Assignee: bhughes at freebsd.org
          Reporter: randy+bsd at terbush.org
             Flags: maintainer-feedback?(bhughes at freebsd.org)
          Assignee: bhughes at freebsd.org

The ports install for www/node is patching common.gypi which includes the
following lines.

```
      ['OS=="freebsd"', {
        # Use this flag because on FreeBSD std::pairs copy constructor is
non-trivial
        #
https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html
        'cflags': [ '-D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1' ],
        'ldflags': [
          '-Wl,--export-dynamic',
        ],
```

Setting _LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 on FreeBSD 11 systems compling with
clang will cause compile of node modules to fail with the following error:

```
gmake: Entering directory '/home/randy/Develop/tkg/node_modules/sharp/build'
  TOUCH Release/obj.target/libvips-cpp.stamp
  CXX(target) Release/obj.target/sharp/src/common.o
In file included from ../src/common.cc:15:
In file included from /usr/include/c++/v1/cstdlib:85:
/usr/include/c++/v1/__config:73:2: error: "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is
no longer supported.        use
_LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR instead
#error "_LIBCPP_TRIVIAL_PAIR_COPY_CTOR" is no longer supported. \
 ^
1 error generated.
gmake: *** [sharp.target.mk:151: Release/obj.target/sharp/src/common.o] Error 1
gmake: Leaving directory '/home/randy/Develop/tkg/node_modules/sharp/build'
gyp ERR! build error 
gyp ERR! stack Error: `gmake` failed with exit code: 2

```

The patch in files/patch-common.gypi needs to be removed at least for newer
versions of FreeBSD.

-- 
You are receiving this mail because:
You are the assignee for the bug.