[Bug 220737] bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR} validation

bugzilla-noreply at freebsd.org bugzilla-noreply at freebsd.org
Fri Jul 14 20:05:05 UTC 2017


https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220737

            Bug ID: 220737
           Summary: bsd.java.mk: Strict JAVA_{VERSION,VENDOR,ERROR}
                    validation
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Ports Framework
          Assignee: portmgr at FreeBSD.org
          Reporter: kevans at freebsd.org
                CC: freebsd-ports-bugs at FreeBSD.org
             Flags: exp-run?

Created attachment 184363
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=184363&action=edit
svn(1) diff of Mk/bsd.java.mk

Noticed while working in the regex around here: validation of
JAVA_{VERSION,VENDOR,ERROR} does not constitute an error and make(1) will
happily continue, potentially doing the wrong thing. Attached patch adjusts it
as follows:

* Only validate each var if it's defined
* Also echo "not a valid value" message if the checked var is empty
* Fail the build if validation fails

-- 
You are receiving this mail because:
You are on the CC list for the bug.


More information about the freebsd-ports-bugs mailing list