[Bug 216468] textproc/pugixml causes inconsistencies with c++11 and later

[bugzilla-noreply at freebsd.org]

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216468

            Bug ID: 216468
           Summary: textproc/pugixml causes inconsistencies with c++11 and
                    later
           Product: Ports & Packages
           Version: Latest
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: Individual Port(s)
          Assignee: freebsd-ports-bugs at FreeBSD.org
          Reporter: riggs at FreeBSD.org
                CC: ybungalobill at gmail.com
                CC: ybungalobill at gmail.com
             Flags: maintainer-feedback?(ybungalobill at gmail.com)

Created attachment 179316
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=179316&action=edit
Enable c++11 on pugixml

pugixml installs a bogus pugixml.hpp file that contains the following section:

...
                // Copy constructor/assignment operator
                xpath_node_set(const xpath_node_set& ns);
                xpath_node_set& operator=(const xpath_node_set& ns);

        #if __cplusplus >= 201103
                // Move semantics support
                xpath_node_set(xpath_node_set&& rhs);
                xpath_node_set& operator=(xpath_node_set&& rhs);
        #endif

...

Right now, pugixml is built without c++11 support. Subsequently, the resulting
library does not contain this move constructor.

If a dependent port, however, is built with -std=c++11/14/1z, it will parse the
pugixml.hpp header and erroneously assume that the pugixml.(a|so) contain the
move constructor. Subsequently, the build will fail with a linker error.

Attached patch enables c++11 for the pugixml port and allow dependent ports
with -std=c++11/14/1z to build again.

-- 
You are receiving this mail because:
You are the assignee for the bug.